-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add eiskaltdcpp.mk to mxe/plugins/apps #1165
base: master
Are you sure you want to change the base?
Conversation
Like this:
Add other Qt components if you need them. Full list of Qt5's pc files can be found in
See |
1)Fixed. |
|
64-bit installer does not need. 32-bit installer completely provides all that is needed. |
@pavelvat, I think it is generally a bad idea to add a package to requirements, if it is built by MXE and can be used. The main problem here is that targets of Can we add the following syntax to
? |
From https://github.com/Alexpux/MINGW-packages/pull/993:
|
Bump cross-target dependency |
Updated for Qt 5.6 and rebased.
Current status: |
plugins/apps/eiskaltdcpp.mk
Outdated
$(PKG)_SUBDIR := $(PKG)-$($(PKG)_VERSION) | ||
$(PKG)_FILE := $(PKG)-$($(PKG)_VERSION).tar.gz | ||
$(PKG)_URL := https://github.com/$(PKG)/$(PKG)/archive/$($(PKG)_VERSION).tar.gz | ||
$(PKG)_DEPS := gcc aspell boost jsoncpp libidn lua miniupnpc nsis qt5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think full qt5
target requires too much build time and disk space.
Could you specify only really used qt
modules?
Required for: mxe#1165
Required for: mxe#1165
Done. |
Required for: mxe#1165
Required for: mxe#1165
Required for: mxe#1165
1d5735a
to
d882d89
Compare
Problems:
1)
$(PKG)_BUILD_STATIC =
because linked error for static builds: http://pastebin.com/A9C4T5VxIt is can be fixed by adding names of depend libraries to https://github.com/eiskaltdcpp/eiskaltdcpp/blob/14bd7229c12f06a4251c8a57795e4121e1b53d01/eiskaltdcpp-qt/CMakeLists.txt#L346
How to get full list names of depend libraries for static Qt5?
2)
$(PKG)_BUILD_x86_64-w64-mingw32 =
because mxe/tools/copydlldeps.py don't work for x86_64, see #5893)#1127 (comment) so 'nsis' from:
can not be build for x86_64-w64-mingw32.static x86_64-w64-mingw32.shared targets. It can be fixed in common case by using Linux package nsis instead nsis.mk.
4)Currently eiskaltdcpp-qt.exe don't launch due to #1143. It can be fixed by editing eiskaltdcpp.mk:
and disabled this lines
because NSIS script required file libaspell-15.dll.
5)Installer enabled only for shared builds because NSIS script required refactoring for support static builds. I will make it in future.
6)line:
work only for i686-w64-mingw32. How to check "if(x86_64)"?
7)Also need manual editing the file:
remove prefix 'std::' from std::sprintf, see #1104